fix(fleet): repin rewrites stale dryrun refs, not just rc refs#392
Merged
Conversation
The repin's in-repo ref rewrite only matched vX.Y.Z-rc.N, so a hand-written setup-cli pin left pointing at a vX.Y.Z-dryrun.N tag (from a dry-run validation repin) was never updated to the current rc. After the dryrun tags were pruned, primary and rollback-dispatch failed at Set up job (Unable to resolve action stablekernel/[email protected]) and the first live nightly fleet went red. Broaden the grep and sed to match -(rc|dryrun). so any stale prerelease pin self-heals to the rc on the next repin. Part of #373. Signed-off-by: Joshua Temple <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first live nightly (cron -> v0.6.0-rc.0 -> fleet) failed: primary and rollback-dispatch could not resolve
stablekernel/[email protected]at Set up job. Cause: those repos had a hand-written setup-cli pin left pointing at a-dryruntag from an earlier dry-run validation repin. The repin's in-repo ref rewrite only matchedvX.Y.Z-rc.N, so a-dryrun.Npin was never updated to the current rc; after the dryrun tags were pruned, the pin became unresolvable.Fix
Broaden the repin grep and sed to match
-(rc|dryrun).so any stale prerelease pin self-heals to the rc on the next repin (verified the regex rewrites both -dryrun and -rc refs and leaves final releases untouched). One file, actionlint clean.Validation
This will be validated on the LIVE rc path (a real
forcenightly dispatch cutting a real rc, fleet green, promote) - not a dry-run - before re-closing #373. Part of #373.